Run all tests with mocha after all #7076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerschmidt
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6956 and #6978, I started porting tests from mocha to the built-in node test runner.
However, having two different test runners complicates things, and the existing coverage reporting (
npm run coverage) also works for mocha only.Actually, the basic API is the same for mocha and the built-in node test runner anyway, and my main concern was with using the OCaml-like API in
mt.resbuilt on top of mocha instead of using the basic mocha API directly like you normally would in JS.So I am now running all tests with mocha again, but keeping the refactorings I already made for the Belt tests. I think all tests should eventually be refactored to this simpler style, but there is no rush here.